Pete Walsh comments

Results 285 comments of


                                            Pete Walsh

Add delivery_info key to message to fix sending tasks over Redis

I'm not able to update this branch for some reason. Can you do it when you get a chance? That should fix the CI errors.

Revoke Tasks

This would be great to have. I'm not entirely sure how it's implemented in Python Celery TBH. My guess is all workers consume from a separate "revoke" queue, and when...

Move amqp and redis support behind feature flags

Can you update this branch?

Add ability to add / define task schedules with the beat macro

I think this is possible, but I don't know too much about macros either. Usually I just try different things until I can get it to compile 😝 I'm totally...

WIP - Adding exchange info when declaring queues.

Thank you @alekhrycaiko, I'll take a look soon!

WIP - Adding exchange info when declaring queues.

@alekhrycaiko, sorry it's been a busy week for so far and I still haven't found time to review PRs, but I'm hoping to get to this by tomorrow.

WIP - Adding exchange info when declaring queues.

> Concerning `CeleryQueue`, I opted for making this explicit to differentiate this clearly from the lapin Queue used in the repo. But, happy to revert to `Queue` if this is...

Implement Redis backend

Hey @morenol! That would be great. I think the steps to tackle this are as follows: 1. Start by designing a `Backend` trait, and show how the `Celery` app would...

Do we need to handle CPU bound tasks differently?

I think the next step forward is to benchmark a worker handling CPU intensive tasks with the following set ups: - current system - with `spawn_blocking` wrapped around `task.run()` -...

Do we need to handle CPU bound tasks differently?

This blog post is very relevant: https://ryhl.io/blog/async-what-is-blocking/