rusty-celery
rusty-celery copied to clipboard
WIP - Adding exchange info when declaring queues.
Related to: https://github.com/rusty-celery/rusty-celery/issues/85
I've taken a stab at trying to implement the above. It's been a bit of an undertaking, but, I think it's in a state that some feedback would be helpful - so that I can iterate/improve it further.
A couple thoughts for missing work currently...
- Testing the declaring and invoking of messages via exchanges. Currently this is not done but would probably make sense :thinking:
- General approach is not as convenient to invoke as a macro :sweat:
Happy to have any feedback and iterate on this as needed :bow: thanks for the patience/input!
Thank you @alekhrycaiko, I'll take a look soon!
@alekhrycaiko, sorry it's been a busy week for so far and I still haven't found time to review PRs, but I'm hoping to get to this by tomorrow.
No problem, and not a rush on my end ( my week has been similar :laughing: )
Hey @alekhrycaiko, this looks like a great start.
I think it would be better to define the
Exchange
andCeleryQueue
structs in either thebroker
or therouting
module. And maybeCeleryQueue
should just beQueue
?
Agreed that moving those structs into one of those options would make sense. I'll make a change concerning that.
Concerning CeleryQueue
, I opted for making this explicit to differentiate this clearly from the lapin Queue used in the repo. But, happy to revert to Queue
if this is preferred.
Concerning
CeleryQueue
, I opted for making this explicit to differentiate this clearly from the lapin Queue used in the repo. But, happy to revert toQueue
if this is preferred.
The queue from lapin
should really be abstracted away by our version of a queue. Internally we could just refer to the lapin queue as lapin::Queue
.