rusty-celery icon indicating copy to clipboard operation
rusty-celery copied to clipboard

WIP - Adding exchange info when declaring queues.

Open alekhrycaiko opened this issue 4 years ago • 5 comments

Related to: https://github.com/rusty-celery/rusty-celery/issues/85

I've taken a stab at trying to implement the above. It's been a bit of an undertaking, but, I think it's in a state that some feedback would be helpful - so that I can iterate/improve it further.

A couple thoughts for missing work currently...

  1. Testing the declaring and invoking of messages via exchanges. Currently this is not done but would probably make sense :thinking:
  2. General approach is not as convenient to invoke as a macro :sweat:

Happy to have any feedback and iterate on this as needed :bow: thanks for the patience/input!

alekhrycaiko avatar Sep 13 '20 16:09 alekhrycaiko

Thank you @alekhrycaiko, I'll take a look soon!

epwalsh avatar Sep 14 '20 16:09 epwalsh

@alekhrycaiko, sorry it's been a busy week for so far and I still haven't found time to review PRs, but I'm hoping to get to this by tomorrow.

epwalsh avatar Sep 17 '20 18:09 epwalsh

No problem, and not a rush on my end ( my week has been similar :laughing: )

alekhrycaiko avatar Sep 17 '20 18:09 alekhrycaiko

Hey @alekhrycaiko, this looks like a great start.

I think it would be better to define the Exchange and CeleryQueue structs in either the broker or the routing module. And maybe CeleryQueue should just be Queue?

Agreed that moving those structs into one of those options would make sense. I'll make a change concerning that.

Concerning CeleryQueue, I opted for making this explicit to differentiate this clearly from the lapin Queue used in the repo. But, happy to revert to Queue if this is preferred.

alekhrycaiko avatar Sep 19 '20 23:09 alekhrycaiko

Concerning CeleryQueue, I opted for making this explicit to differentiate this clearly from the lapin Queue used in the repo. But, happy to revert to Queue if this is preferred.

The queue from lapin should really be abstracted away by our version of a queue. Internally we could just refer to the lapin queue as lapin::Queue.

epwalsh avatar Sep 21 '20 16:09 epwalsh