Eric Pugh

Results 697 comments of Eric Pugh

@dsmiley I went through your comments and followed them. I think this is now ready. Thanks for going through a rather LONG PR. In retrospect, I wish I had separated...

@dsmiley I am merging to main and branch_10_x, but NOT branch_10_0. Thanks for the review on this.

@dsmiley is it possible that part of the scope of this is to remove the `CommonParams.TRACK` property? The comment for it is `value indicating an interest in debug output related...

> @dsmiley is it possible that part of the scope of this is to remove the `CommonParams.TRACK` property? The comment for it is `value indicating an interest in debug output...

@dsmiley I've poked again at this, and I would love fresh eyes on this.... Would you be willing to take a look? It's so close...

I think I'll look at getting more of these done post Solr 10.0 being released...

@dsmiley I think I still have a couple comments of yours to go through, however I was finally able to remove `DirectSolrConnection`. I don't know that I embraced the `EmbeddedSolrServer`...

I asked Claude about LocalSolrQueryRequest versus EmbeddedSolrServer pros/cons and this is hwat he said: Aspect | LocalSolrQueryRequest (Current) | EmbeddedSolrServer (New Option) | |--------|--------------------------------|--------------------------------| | **Level** | Core internals |...

Okay, I made the change in `SolrTestCaseHS`. I asked Claude about doing the same in `SolrTestCaseJ4` and he said: Should we make the same change?** **Actually, no!** Here's why the...

I fixed the imports and removed the deprecated methods, this is ready for review.