Eric Pugh
> Impressive results! > > I'd much prefer to see testcontainers. I don't trust mocks in the slightest mocking some external system. Who knows if what we mock is trustworthy...
Also, I wonder if instead of a whole new module, what if we just forced this into the ExtractingRequestHandler.java, and kept it in /extraction? Or do we think it's cleaner...
> Great initiative. Warning is a nice thing to add since it is easy in a centralized way, but not strictly required if this is a 10.0 PR and the...
> It's not clear this is needed or matters. In the code I like seeing "solr.." wehre the module and name are camel case. But I can get over it....
We should probably make sure we are all on the same page, before I keep plugging away on this. I, maybe erroneously, assumed that since there was a TODO in...
Okay, before I polish off migrating the rest of the ones in https://github.com/apache/solr/pull/3312/files#diff-012f0766c431d2622a99ac1f70addc1d1f90106816a94434a39db6945db23601, I think this should probably get merged, and then I can do a second batch...?
Thanks for letting oking at this! I had tuna but out of steam on it but will try and pick it up again and get this batch of changes in....
Just picking this up again and getting synced to latest... I am thinking this would only go to Solr 10.... Thanks for the comments @janhoy ....
Just added a JIRA. I would like to get this batch committed, before I do more.....
> The upgrade guide ought to list old/deprecated properties, right? Or if not then, if I'm seeing this code correctly, we log a warning if one is used? Correct. There...