Eric Sniff

Results 15 comments of Eric Sniff

@araddon I added indentation to the printing of the AST: ``` epsniff@hms-victory:...n/qlbridge/vm$ go test --run TestDateMath/FILTER_NOT -v === RUN TestDateMath === RUN TestDateMath/FILTER_NOT_last_event_ "now-3x" negated:false node *expr.IdentityNode last_event negated:false node...

sounds good to me. I'll try to think of ways that wouldn't' work and comment here if I can think of any.

This would be a big optimization for some access patterns. Ill take some time to think about the changes need for this. Off hand I believe we'd have too: -...

One possible solution would be to write to a remote tmp file and then in writer.Close() to move/rename the file to its final location.

There isn't a backing file when you use store.NewWriter since it writes/pipes directly to the target source. I know GCS the best, so in GCS when you begin piping the...

ref: https://github.com/lytics/cloudstorage/pull/53/files#diff-9bae92b1bb719d9453e4c3469e9e7c8aR560 and https://github.com/lytics/cloudstorage/pull/53/files#diff-d96c12e79c906a3ad1845c783ac6a5c0R247 This lines both destroy the file when the writer is created. We should discuss how big of a deal that is, maybe its fine? We'll never...

That seems ok to me. So the change would be to use the provided when creating this [context]:(https://github.com/lytics/grid/blob/master/server.go#L109) instead of a `context.Background`. I'd suggest passing in the "provided` context via...

I ended up using Aaron's QLBridge parser, to create an interesting DSL for selectors and labels. Interested in feedback.

Is rebalancing an issue currently? A time based method seems more KISS, because it doesn't rely on the event loop and balance calls being as tightly coupled.

Im all for limiting dependencies. Can we use expvar without automatically exposing it via HTTP? IMO, surfacing the metrics should be left to the hosting project.