Sebastian "Sebbie" Silbermann
Sebastian "Sebbie" Silbermann
Completes https://github.com/facebook/react/pull/28005 Haven't checked if the changed assertions makes sense. Should this test instead be considered a legacy test and gated @kassens?
Batched the remaining usages since these were straight forward. Completes removal of `ReactTestUtils` from tests unrelated to `react-dom/test-util` together with: - https://github.com/facebook/react/pull/28531 - https://github.com/facebook/react/pull/28532 - https://github.com/facebook/react/pull/28533
```diff -expect(ReactTestUtils.isDOMComponent(maybeElement)).toBe(true); +expect(maybeElement).toBeInstanceOf(Element); ``` It's not equivalent since `isDOMComponent` checks `maybeElement.nodeType === Element.ELEMENT_NODE && !!maybeElement.tagName` but `instanceof` check seems sufficient here. Checking `nodeType` is mostly for cross-realm checks and checking...
## Summary Removes every API from `react-dom/test-utils` except `act` in favor of using `@testing-library/react`. Removal is gated behind `disableDOMTestUtils` that's off for Meta builds. The functions aren't removed but instead...
## Summary Closes https://github.com/facebook/react/issues/28556 We didn't follow the Rules of Hooks in the rerender implementation for mounts. ## Test plan - Added test based on "useFormState updates state asynchronously and...
**Describe the issue** I noticed that our `post-checkout` was taking a fairly long time when doing a `git-checkout`. It was almost always taking roughly 3.5s1. Once I ran `git config...
## [10.0.0-alpha.2](https://github.com/testing-library/dom-testing-library/compare/v10.0.0-alpha.1...v10.0.0-alpha.2) (2023-10-03) ### Bug Fixes * use defineProperty on the error object instead of setting the message directly ([#1268](https://github.com/testing-library/dom-testing-library/issues/1268)) ([3580f25](https://github.com/testing-library/dom-testing-library/commit/3580f25bd765cedb70889b2cf716085023d8c314)), closes [#1259](https://github.com/testing-library/dom-testing-library/issues/1259) ### Features * upgrade aria-query to 5.3.0...
- `waitFor#options.container` can be `Document | Element` not just `HTMLElement` - added `waitFor#options.showOriginalStackTrace` - `config.getElementError` accepts `Document | Element` not just `Element` - `config.unstable_advanceTimersWrapper` has no bound `this`