Sebastian "Sebbie" Silbermann

Results 164 issues of Sebastian "Sebbie" Silbermann

Seems like they were never tested. I'm not sure if the two added tests can be fixed with independent commits.

## Summary Alternate to https://github.com/facebook/react/pull/24440. I needed a CI build to test the published package ## How did you test this change? - [x] CI - [x] Testing all entrypoints...

CLA Signed

Waiting for release of https://github.com/facebook/jest/pull/13328 ## Summary - unhandled errors from JSDOM are now proper errors instead of strings - no more `abortSignal.reason = ...` hack in JSDOM environments -...

CLA Signed

**Describe the bug** When a package has dependencies to node builtins e.g`import * as fs from 'node:fs'` then bundlephobia thinks this is an undeclared dependency **To Reproduce** https://bundlephobia.com/package/node-fetch-retry **Expected behavior**...

bug

While yarn v2 is still in development alphas are already released and documented: https://yarnpkg.github.io/berry/ Since I'm a big fan of dependabot and yarn v2 I would like those two to...

T: feature-request
L: javascript:yarn
F: language-support

This is the proper patern to augment global interfaces that are defined by the runtime (see https://github.com/DefinitelyTyped/DefinitelyTyped/pull/60837#pullrequestreview-1009631323) The previous approach would break once `lib.dom.d.ts` declares these interfaces. The previous approach...

Critical package
Unreviewed
Edits Owners

### Summary Allows creating JSON files of compilation stats that can be analyzed with https://statoscope.tech/ Command-line argumes take precedence over options in `webpack.config.js` Copied behavior from webpack-cli: https://github.com/webpack/webpack-cli/blob/26ba6a82e7bc596e7fe48db9028f79e65e8131bc/packages/webpack-cli/src/webpack-cli.ts#L2291-L2299 Based on...

Stacked on [#25383](https://github.com/facebook/react/pull/25383) ([Diff against #25383](https://github.com/facebook/react/compare/eps1lon:forwardRef/deprecate-string-refs-only...eps1lon:forwardRef/remove-string-refs)) ## Summary Part of https://github.com/reactjs/rfcs/blob/createlement-rfc/text/0000-create-element-changes.md#deprecate-string-refs-and-remove-production-mode-_owner-field Removes support for string refers which allows moving `_owner` to a non-enumerable, dev-only property (like `_self` and `_source`). `_owner`...

CLA Signed

## Summary For [reactjs/rfcs@createlement-rfc/text/0000-create-element-changes.md#deprecate-string-refs-and-remove-production-mode-_owner-field](https://github.com/reactjs/rfcs/blob/createlement-rfc/text/0000-create-element-changes.md?rgh-link-date=2022-09-25T12%3A04%3A41Z#deprecate-string-refs-and-remove-production-mode-_owner-field) Enable `warnAboutStringRefs` for every release. I adjusted the warning logic to not also appear in other cases where we already warn/throw (e.g. function components cannot be...

CLA Signed

## Summary Alternate to https://github.com/facebook/react/pull/25334 without any prod runtime changes i.e. the proposed codemod in https://github.com/reactjs/rfcs/blob/createlement-rfc/text/0000-create-element-changes.md#deprecate-string-refs-and-remove-production-mode-_owner-field would not work. ## How did you test this change? - [x] CI -...

CLA Signed