Sebastian "Sebbie" Silbermann

Results 555 comments of Sebastian "Sebbie" Silbermann

I can also merge. @remcohaszing just let me know if this is ready to go

`React.ComponentPropsWithRef` is the props object `div` (or here `Component`) can receive. However, you use it in a position that the component implementation sees. These are two different things since you...

Do we know what this was used for and what should be used instead? Is there any usage of this type in this repo?

> Seems like only brainhubeu__react-carousel was using this interface. And how would we resolve the breaking change there? This is essential to deprecating a type. We need to have an...

Yeah that makes sense if that's the best migration path we can offer. But it needs to be documented in the PR.

Thanks but we landed this in https://github.com/testing-library/dom-testing-library/pull/1208.

Does anybody have a minimal repro for that? Ideally a TypeScript playground but a git repo works as well. Please reduce it to as little code as possible.

Note that `lastmessageRef` as a dependency won't do anything and can be removed. The effect won't fire if `lastmessageRef.current` changes. Could you include a video of the behavior in Firefox...

Also possible duplicate of https://github.com/facebook/react/issues/11538. See https://github.com/facebook/react/issues/11538#issuecomment-417504600 for the latest update.