Sebastian "Sebbie" Silbermann
Sebastian "Sebbie" Silbermann
I'm not fundamentally opposed. But the added dimension due to the naming of the option is a bigger concern for me right now.
It's not an either or answer. Sure if I expect an object in a prop and the user gives me a number then my component will not work as intended...
@ljharb That PR only downgrades the deprecation warning from `console.error` to `console.warn`. This PR downgrades **all**. If anything #63 should be closed over this one.
> Seems like we might want to add this as a breaking change for 19 then? Maybe add it behind a flag in experimental for now so we know to...
@sebmarkbage I could add `hidden` to `OVERLOADED_BOOLEAN` which would ensure compat with `inert=""`. This also has the benefit to prevent future compat issues like `hidden` has: adding support for `hidden="until-found"`...
What about allowing `aria-sort` on `role="list"`? ```diff - + - +
It's not possible just like it's not possible to call `render` with props for the wrapper. The `initialProps` are passed to the render callback which we have documented in https://testing-library.com/docs/react-testing-library/api/#renderhook-options...
We'll also need to look into support for `beforematch` events and we need to decide if we're ok with experimental APIs that are only supported by a single browser.
Last time I used lint rules using typechecking, it made ESLint horribly slow. Is ESLint report still blocked on the slowest rule or is in-editor linting streaming in results as...
Pretty sure this is a general problem when we reach into `*Props` but ignore theme default props.