Sebastian "Sebbie" Silbermann

Results 555 comments of Sebastian "Sebbie" Silbermann

> So, it's for sure a bug in react. Note that this could still be a browser bug if it's not implementing the spec correctly on which React may rely....

Smaller repro: https://codesandbox.io/s/cocky-fermat-qoiel3 Basically two `setState` calls that are separated by a microtask are not applied in-order

But `fn` is missing. I don't get any different behavior when removing `T`. What is producing a false-positive is ```tsx useEffect(() => { const fn = () => { const...

Some CI shards are failing with out-of-memory errors. Going to take a while identifying the memory leaks.

> Anything blocking this? I noticed an issue when running `updateSnapshot` on `useId` tests (running `--updateSnashot` without https://github.com/facebook/react/pull/21575/commits/e44ea790c98e79804c40619ffd8a6b7ef3869f40). So I'd like to check if this is already broken on `main`...

@gaearon https://github.com/facebook/jest/issues/11561 is blocking this update. Jest without `--updateSnapshot` would be quite boring.

@SimenB Currently stuck on 28. Seems like Jest now requires file extensions in the imports? ``` ENOENT: no such file or directory, open '/home/eps1lon/Development/forks/react/packages/react/src/ReactSharedInternals' 146 | // the React package...

> I'll fix in Jest 29, but if you wanna land v28 you'll need patch-package or something (or add the extension). We need 29 for the JSX inline-snapshot fix so...

@SimenB https://github.com/facebook/jest/pull/13328 seems to be the last blocker. Full test suite was green now locally with https://github.com/facebook/jest/pull/13328 applied.

I understand that people want this to count as a hook but also consider the larger ecosystem impact. `jest.useFakeTimers` is an often used API that would start triggering this rule...