Sebastian "Sebbie" Silbermann

Results 555 comments of Sebastian "Sebbie" Silbermann

What's also very important is the environment e.g. which browser or if you're running from node (via e.g. `jest`) what version of `jsdom` (`yarn why jsdom` or `npm ls jsdom`).

> Can anyone give context on why Yarn is ignoring/breaking the Node resolution algorithm? I guess https://yarnpkg.com/lang/en/docs/pnp/ is a good primer?

> @eps1lon could you confirm if that works? ```json "devDependencies": { "@sapper/app": "link:./src/node_modules/@sapper/app", "@sapper/server": "link:./src/node_modules/@sapper/server", "@sapper/service-worker": "link:./src/node_modules/@sapper/service-worker" } ``` works: https://github.com/eps1lon/berry-sapper/pull/1 Just using `@sapper` caused ` package is trying to...

> @sapper isn't a valid package name so it should have been rejected outright smile btw, I think I added it manually to the package.json. `sapper` and `svelte` still need...

Duplicate of https://github.com/donavon/use-interval/pull/34

> @eps1lon is this a regression we missed in the last PR that ended up being 2.2.0 - or new functionality? Tried the tests in 2.1.0 (`git checkout v2.1.0`) and...

> Only webkit properties are in the spec; other engine prefixes should not be added. This statement clashes with https://github.com/jsdom/cssstyle/blob/ebd2dab41a3396419513a7698cdd37494727d0da/lib/allExtraProperties.js#L4-L5

@jsakas Is there anything I can do to get this merged?

> Are you able to resolve the conflict for me? Sure thing. > Also, based on @domenic's comment I think only webkit should be supported at this time. Personally I...

Can't reproduce with Chrome Version 98.0.4758.102 (Official Build) (64-bit) on Ubuntu 20.04. What is the reason you're using `event.nativeEvent` and not `event` directly?