scoringutils icon indicating copy to clipboard operation
scoringutils copied to clipboard

Reduce number of `try()`, `suppressMessages()`, `suppressWarnings()` used in the package

Open nikosbosse opened this issue 9 months ago • 1 comments

scoringutils codebase contains a lot of try(), suppressMessages(), suppressWarnings(). This is likely the symptoms that a refactoring or redesign is necessary. In particular, one potential cause can be the lack of delineation between internal and external functions, as discussed in the earlier NAMESPACE section.

try(), suppressMessages(), suppressWarnings() should usually be a last resort, and not a common pattern in the codebase. Since they affect all conditions, not just conditions created by scoringutils, they can also hide deeper issues, and make debugging harder.

Originally posted by @Bisaloo in https://github.com/epiforecasts/scoringutils/pull/791#pullrequestreview-2003401135

nikosbosse avatar May 19 '24 09:05 nikosbosse