Ed Page

Results 4043 comments of Ed Page

> If any feature removed in the previous was explicitly requested, error Wouldn't this still be a semver breakage for `bar` to require `foo`? Without the error, we are disabling...

See https://internals.rust-lang.org/t/listing-of-cargo-features/16867/6

I think the ideal is to hide them if they are not directly enabled. It should be possible to implement this at end of the preparation when we print the...

We've talked about this at the cargo team meeting. We are reluctant to move forward with this for now; we'd like more time before committing to this. We'd like the...

In cargo, we first run ```rust let (expanded_args, global_args) = expand_aliases(config, args, vec![])?; ``` and later call ```rust config_configure(config, &expanded_args, subcommand_args, global_args)?; ``` which reads the `--config` flag. Resolving this...

> Nonetheless, there seems to be no way to explicitly inform Cargo that you actually know this is a top-level ie. not-a-workspace project. You could always workaround this by putting...

> The expected content of the newly created Cargo.toml: Yes We have to make sure fields like `edition` are overwritten rather than duplicated (a risk if simple string manipulation is...

Tips - You most likely want `find_workspace_root` to find the workspace root. - Loading the workspace to find the root might fail because of #6378 - The fix for #6378...

https://github.com/ordian/toml_edit/issues/133 is the tracking issue for getting feature parity for `cargo`. We might also need - https://github.com/ordian/toml_edit/issues/128 - https://github.com/ordian/toml_edit/issues/192 - https://github.com/ordian/toml_edit/issues/205

> Hyphens in crate names suck for all sorts of reasons, see [hyphens considered harmful](https://rust-lang.github.io/rfcs/0940-hyphens-considered-harmful.html#disallow-hyphens-in-crates-only). Unfortunately, cargo will happily allow you to upload a crate with a hyphen without warning....