Ed Page

Results 4043 comments of Ed Page

My proposal is to expand the filter/tag API so that they can document their behavior. The top-level `Parser` could either dump the results or let users iterate on it, unsure...

Looks like this broke some other cases somehow.

They use `environments` https://github.com/Shopify/liquid/blob/master/lib/liquid/tags/increment.rb#L24 https://github.com/Shopify/liquid/blob/master/lib/liquid/context.rb#L163 Not sure when the squash is used https://github.com/Shopify/liquid/blob/master/lib/liquid/context.rb#L215

Note: to get the max recursion from the end-client to the linked `Context`, it'll need to pass through the following layers - ParserBuilder - Parser - Template - ContextBuilder -...

Max recursion: - Let's say the default could be 1000 - We can use `Option` so someone can disable the recursion limit test

> The bug marks "fn run_in_named_scope()" as being the location to fix. Wouldn't the recursion in "fn run_in_scope()" also be at risk for infinite recursion? Good question. This requires some...

I license past and future contributions under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option

Checklist of post-1/8/2016 contributors that have posted their agreement - [x] @epage - [x] @gmalette - [x] @djwf - [x] @fiji-flo - [x] @dzamlo - [x] @vvv - [x] @kubahorak...

1. I'd say this implementation is safer. The ruby version blurs the line between liquid and ruby and they have to go through extra hoops to ensure it is safe....

So a static analysis profiler, interesting. I'll have to give this some thought on the best way to handle it. On a related note, we also need to take care...