Ed Page

Results 4043 comments of Ed Page

Either way, if you are up for contributing it back, that'd be great! We are working on having the official liquid filters, shopify, jekyll, and custom, see https://github.com/cobalt-org/liquid-rust/tree/master/crates/lib/src

The issue is the error reporting for the `expect` functions loses all error information

Granted, the second one doesn't provide line numbers. @Goncalerta, have any suggestions for how to get both of these errors to include both line number and the "available filters"?

One tricky thing will be to separate implementation concepts, bugs in liquid-ruby, and bugs in liquid-rust. For example `{{ 5.size }}` in the Ruby implementation returns how many bytes `5`...

It does? Thats disappointing. If you use a CI to build your site, it is unpredictable what time zone it will be in. Oh, well. The joy of compatibility.

Agreed though I think it might be nice to offer a feature flag to change from local to UTC.

Yes, we need to resolve #419 and close the gap on that. Unfortunately, a lot of my attention is elsewhere atm so I'm not getting to spend as much time...

Most definitely!

I finished porting over all (relevant) liquid (ruby) integration tests to Rust (see `conformance_ruby`) and am still in the middle of annotating them with issues. At that point I'd update...

RE liquidjs I guess technically this isn't needed for conformance since newlines are ignored in HTML and this tag exists to emit HTML but it makes it much easier to...