nighthawk

nighthawk copied to clipboard

Investigate textproto parsing, absl::Status matchers, and similar unit test conveniences

2

eric846

When adding an include from a directory not explicitly specified in our check_format scrips, the automatic formatting fixing may produce output that gets flagged by the formatting check. That's less...

oschaaf

For example `MakeFakeInputVariableSetterConfig()` doesn't return a `FakeInputVariableSetterConfig`, it returns a `TypedExtensionConfig` with a `FakeInputVariableSetterConfig` packed into an `Any` in the `typed_config` field. It should be renamed `MakeFakeInputVariableSetterTypedExtensionConfig()`.

eric846

In our `BUILD` files, in `envoy_cc_library`, we have lots of repetition with respect to declaring visibility of targets. It would be nice if we could set this at the package...

oschaaf

Consider consolidating IsConverged and IsDoomed in Adaptive Load StepController

1

Both are const methods that can change value from the same events. - We might think of other predicates. - It could also allow us to encode constraints like doomed...

eric846

Leaving a note here inspired by the discussion over at https://github.com/envoyproxy/nighthawk/pull/477#discussion_r476803233 Tracking the delta's between inbound requests per worker at the test server may yield interesting data. In particular, it...

oschaaf

Use taskset/cpuset when starting processes

5

Hi, I've seen this task between the ones in the TODOs section. I am planning to experiment with this, but I have some initial questions: - Are there any ongoing...

fktkrt

Currently it uses a boolean return code plus optionally written output parameter, increasing the temptation to use "" to convey information.

eric846

Casting an integer to an enum outside the defined range doesn't throw but produces undefined behavior. And C++ has no maintainable way to check for the largest value in this...

eric846

eric846