Saman

icon location Chicago, IL icon location Software Engineer

Results 35 comments of Saman

Parsing from proto should keep field ID. (fixes #7645)

@dbaileychess Could please help me with review this p.r.

Parsing from proto should keep field ID. (fixes #7645)

@dbaileychess This tiny p.r. from last year needs review :)

Fix java import wild card

@dbaileychess could you help me with review this p.r. ?

[Rust] Support no_std environments without `alloc`

I think it is a similar issue to https://github.com/google/flatbuffers/issues/7618 and https://github.com/google/flatbuffers/issues/7765

Relative include paths in the generated `*.hpp` files

If I understand correctly, you want specific path prefix. Maybe you can use` --include-prefix /flatbuffers`

Fix Rust codegen escaping field in tables.

Hi @CasperN , The problem is when we have a field that match with one of keyword, the namer add suffix (underline [here](https://github.com/google/flatbuffers/blob/cf89d1e75625ed46fdf365b1d691ddfaf586f0c0/src/idl_gen_rust.cpp#L49)). As in the comments describe the problem...

Why GetRootAs does not support using a pointer plus length as a parameter to a function

I have found that it is like this in luatest.lua file : `local mon = monster.GetRootAsMonster(buf, offset)`.

Including Flatbuffer in existing CMake project, test fails.

I think if you turn off FLATBUFFERS_BUILD_TESTS, it will work for you

Including Flatbuffer in existing CMake project, test fails.

You can chane --bfbs-filenames in compile_flatbuffers_schema_to_binary function in CMakeLists.txt to `--bfbs-filenames "${CMAKE_CURRENT_SOURCE_DIR}/${SRC_FBS_DIR}"` and then it will work

Parsing from `proto` should keep field ID.

would you mind if I do it ?