Results 8 comments of Niko Stotz

I agree these comments don't adhere to the grammar. Unfortunately, I have limited influence how the files are written. As a workaround, we could have a flag that _disables_ the...

Created Eclipse Bug https://bugs.eclipse.org/bugs/show_bug.cgi?id=540443 Working on it at https://github.com/enikao/eclipse.platform.text/blob/Bug_540443/org.eclipse.ui.genericeditor/src/org/eclipse/ui/internal/genericeditor/ProblemMarkerCodeMiningProvider.java

I replaced the unicode symbols by icons (as proposed by @vogella): ![image](https://user-images.githubusercontent.com/2211690/47573044-a8ea6980-d93c-11e8-9a02-e556b78d82e9.png) Outstanding issues: * I currently re-use the icons from org.eclipse.ui.internal.ide.IDEInternalWorkbenchImages. What's the right thing to do here? Ignore...

Thanks for the hint @angelozerr, I'll continue the discussion there.

There is actually one aspect regarding JDT. The Java editor also shows the minings, without any changes outside the generic editor: ![image](https://user-images.githubusercontent.com/2211690/47577379-0a173a80-d947-11e8-9d23-1c08774a7362.png) In this screenshot, I just entered "asdfasdfads" +...

`details` model is temporary, so it should not under VC, right?

I think it automatically adds the dependency as soon as we create the `Override` inside `coarse`, because we refer to a `StringDetail` in `details`. We could argue that in this...

I agree these comments don't adhere to the grammar. Unfortunately, I have limited influence how the files are written. As a workaround, we could have a flag that _disables_ the...