enhancient

Results 29 comments of enhancient

Hi @MarcoMig, I'm not sure if this helps, but I had success using a nib approach: let nib = UINib(nibName: "HeaderCollectionReusableView", bundle: nil) self.collectionView?.register(nib, forSupplementaryViewOfKind: CHTCollectionElementKindSectionHeader, withReuseIdentifier: "collectionHeader")

@nathantannar4 InputBarAccessoryView looks great - so why doesn't this project leverage that work considering you are a collaborator on this project? If I use InputBarAccessoryView now for the extra buttons...

@nathantannar4 thanks, that's useful 👍

> For `panAxis`, I think PdfViewer should honor the programmer's intension; I want to remove `_calcPanAxis` function: > > https://github.com/enhancient/pdfrx/blob/enhancient/lib/src/widgets/pdf_viewer.dart#L441 Yes, this makes sense - I've actually found a much...

> I think PdfPageAnchor and PdfPageFit conflicts each other. In theory, their roles seem very similar and could be integrated into one. > > I'm gradually deciding that we must...

> And, another topic here is what's the fit zoom ratio. For facing pages view, the fit ratio should be double-page width and the current logic could not allow such...

Looking closer at this, I agree additional info was required for the PdfPageLayoutFunction - I've added pageFitWidths and pageFitHeights that are calculated based on the page fit and I think...

Looking at the most popular PDF readers on Android, none of them implement an overscroll stretch or flow effect. It seems that they all vary slightly with some allowing overscroll...

> At least, `_calcPageSizes` and `_calcCoverFitScale` contains such code and hotestly (I don't intend to blame you), I could not understand your intention of these uses so far... I am...

> Mmm, even if we introduce something like fitHorz, we should also handle facing-page case in some custom way. It should be more configurable... I think a facing-page layout could...