engn33r comments

Repositories
Issues
Comments

Results 84 comments of


                                            engn33r

self.ws.run_forever() causes Stack Overflow

We cannot help you without understanding more details. Please follow the [contributing guidelines](https://github.com/websocket-client/websocket-client/blob/master/CONTRIBUTING.md#i-got-an-error-or-i-have-a-question) and provide the required information to get answers.

Adding logic to allow the client to decide if the websocket frame mask should be used when sending messages.

I'll look again soon to collect any final comments before merging, but I wanted to say this looks good, thanks for the PR :+1:

Always call on_error

If I understand correctly, the intent here is to resolve #970. I need to check if this is the best solution or if another approach is better.

Websocket connection sometimes wrongly drops when using HTTPS

Try v1.9.0, it fixed a number of bugs in #1036 including bugs related to SSL edge cases