websocket-client icon indicating copy to clipboard operation
websocket-client copied to clipboard

Always call on_error

Open KoenVda88 opened this issue 11 months ago • 2 comments

on_error should be called even when we are in reconnected state.

If not the on_error will be called when we lose the connection the first time but not the second time

KoenVda88 avatar Jan 31 '25 13:01 KoenVda88

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 88.02%. Comparing base (75a361a) to head (7d6f400).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1016      +/-   ##
==========================================
+ Coverage   87.97%   88.02%   +0.05%     
==========================================
  Files          14       14              
  Lines        1605     1604       -1     
  Branches      305      304       -1     
==========================================
  Hits         1412     1412              
  Misses         96       96              
+ Partials       97       96       -1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Nov 09 '25 14:11 codecov[bot]

If I understand correctly, the intent here is to resolve #970. I need to check if this is the best solution or if another approach is better.

engn33r avatar Nov 09 '25 23:11 engn33r