Ahmed Saed

Results 39 comments of Ahmed Saed

Thanks @JJJ I will create a PR tonight for this one.

@JJJ I can see that you created a PR for that one. Sorry for being late but I was investigating this one as I found that if we used ```...

I will try doing another approach today and by this weekend I think I will solve that, Yes I will do my best not to use this suppress. Thanks, Boss.

WoW that's a great explanation John, many thanks. I totally agree having a cache class to have all the cache attributes and methods that can be used in all other...

Thanks @JJJ for this detailed comment and sorry for late reply here. After checking your comment and the code here: https://github.com/berlindb/core/blob/2d94af59a0d5642b659af7b62c7674811f25df00/src/Database/Query.php#L2035-L2036 I think there is no way to do this...

@JJJ when we truncate the table we don't touch the meta and cache, right?

No plz, we don't need additional CRON. I checked the preload code and I can see only two places that are creating/updating DB cache rows as below: 1. When the...

@CrochetFeve0251 has a concern regarding, When the user clears cache or even the automatic cache is run before the user applied the new filter. After some discussions, We agreed to...

@barryhughes what do u think about the following grooming: Here: https://github.com/woocommerce/action-scheduler/blob/f2abbce98bcde7113a8c9bcb3e3dae2ee6a2cae3/classes/data-stores/ActionScheduler_DBStore.php#L435 when the date is sent, we may replace this line with the following: ``` $sql .= " AND a.scheduled_date_gmt...

I believe u r totally right, I didn't consider this in my approach. But the snippet u mentioned is used to return all tasks that are scheduled before now but...