Alex Myers
Alex Myers
I haven't been able to replicate this flake locally. The gossip store should look something like this under the nominal case: 1 DELETED Private channel_announcement 2 DELETED private channel_update 3...
Looks to be the same issue as [#5387](https://github.com/ElementsProject/lightning/issues/5387). Should be resolved with [PR #5400](https://github.com/ElementsProject/lightning/pull/5400)
> In particular, private updates are _never_ spam. It's funny how obvious this is in hindsight. Makes the code much more reasonable. Thanks!
I added a shell-check ignore statement to silence the lint warning, however when testing again with the latest snap-installed bitcoin-core, the standard naming conventions (bitcoind, bitcoin-cli) were used along with...
This still had a couple failing tests, but the logs have now expired. Do you want help getting this PR through CI @ErikDeSmedt?
I think more rapid response would help, but like you suggest in making it fuzzy, I worry it gives away some of the channel state when it's too fast. Another...
I just installed v1.2.0 via snap, which was incompatible with [warnet](https://github.com/bitcoin-dev-project/warnet). Either removing it from the docs or publishing to snap automatically would be nice.
Pushing a changelog entry to get CI running.
Looks good. Nit: rather than passing through the bitcoind sematics, could the CLN option be named something similar to the existing `bitcoin-retry-timeout`? Maybe just `bitcoin-rpc-timeout`? Sorry to bikeshed.
This wasn't intended for reckless, but it could be useful if we had it.