Daniel Robertson

Multiple hx711s wastes PIO/SM resources

1

Each time a hx711_t is init'd, a copy of the PIO program is inserted into one of the RP2040's PIOs. It should instead: - check if the program already exists...

Scale functionality should be separated

3

This repo should focus solely on communicating with a HX711. Functionality built on top, such as a scale for measuring weight, is out of scope and should be removed/moved into...

Should the HX711 class try to keep the chip's state?

1

https://github.com/endail/hx711/blob/42d6305ab0aa8ad03e066a67a64228dc67bef4be/include/HX711.h#L83-L86 Perhaps leave it up to the consuming app to decide?

https://github.com/endail/hx711/blob/42d6305ab0aa8ad03e066a67a64228dc67bef4be/src/HX711.cpp#L104 The conditionals to check for these flags waste precious CPU cycles in what is an ultimately critical section. Perhaps a preprocessor flag should be used to gate them instead?

https://elinux.org/RPi_GPIO_Code_Samples#lgpio_.28local_.2Fdev.2Fgpiochip_I.2FF.29 etc...

AdvancedHX711Test.cpp Calibration.cpp SimpleHX711Test.cpp test.cpp

Watcher duration values need to be discoverable, not hardcoded, for optimal performance

2

https://github.com/endail/hx711/blob/5556eb0fe2c6f404938aeec1f3647b035ac49ef6/include/Watcher.h#L49

For the sake of consistency and to avoid confusion with Pico/RP2040 HX711 repos, rename this repo to hx711-rpi-cxx. Note the breaking autobuild notification changes to hx711-rpi-py.