starlette

starlette copied to clipboard

Wrong type.

Kludex

# Summary Implement the ETagMiddleware to drop the response body if the content not changed. # Checklist - [x] I understand that this PR may be closed in case there...

keakon

fix: regex inside function get_route_path to remove root_path

1

Issue: https://github.com/encode/starlette/issues/2599 Discussion: https://github.com/encode/starlette/discussions/2495 # Summary Change regex used to remove root_path to consider only the root path without match simillar endpoint that contains the root_path as substring. ex: ```...

gabriel-f-santos

Private imports from `httpx`.

7

Prompted by https://github.com/encode/httpx/discussions/3287 --- `starlette` is currently using private imports from `httpx`... https://github.com/encode/starlette/blob/c78c9aac17a4d68e0647252310044502f1b7da71/starlette/testclient.py#L500-L513 These are broken against the latest minor point release, which includes this (internal) refactoring... https://github.com/encode/httpx/pull/3245 --- It's...

lovelydinosaur

Add support for ASGI `pathsend` extension

1

# Summary As per title, this adds support for [ASGI pathsend](https://asgi.readthedocs.io/en/latest/extensions.html#path-send) extension on `FileResponse` class for servers implementing it. This is a re-work of #2435 combined with parts of #2616,...

gi0baro

# Summary Resolve the bug (or limitation) in [this related discussion](https://github.com/encode/starlette/discussions/2522) where `Request.url_for()` cannot be called in a middleware inheriting from `BaseHTTPMiddleware` before the `Router`/`call_next` is invoked. # Checklist -...

Jdsleppy

request body get empty when using middleware to save request to contextvar

3

I want to save request to ContextVar so I can use it anywhere. Here is code sample: ```python from contextvars import ContextVar import uvicorn from fastapi import FastAPI from starlette.middleware.base...

LoadingZhang

When the directory itself being a symlink does not work.

2

My test code: ```python from fastapi import FastAPI import uvicorn from staticfiles import StaticFiles app = FastAPI() app.mount("/music", StaticFiles(directory="/home/hanxi/work/xiaomusic/music", follow_symlink=True), name="music") uvicorn.run( app, host=["::", "0.0.0.0"], port=3333, ) ``` The directory...

hanxi

After this, we can implement on Uvicorn side. We may have too much noise from other responses, tho? We should probably supress the others.

Kludex

Use less private imports on the testclient module

3

- Closes https://github.com/encode/starlette/issues/2673

Kludex