starlette icon indicating copy to clipboard operation
starlette copied to clipboard

Add support for ASGI `pathsend` extension

Open gi0baro opened this issue 1 year ago • 1 comments

Summary

As per title, this adds support for ASGI pathsend extension on FileResponse class for servers implementing it.

This is a re-work of #2435 combined with parts of #2616, as discussed in #2613 with @Kludex.

Checklist

  • [x] I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • [x] I've updated the documentation accordingly.

gi0baro avatar Aug 22 '24 14:08 gi0baro

@Kludex I just rebased from current master for your convenience

gi0baro avatar Oct 03 '24 10:10 gi0baro

@Kludex what's your current take on this? Should I rebase so it can be merged, or should we just forget about it?

gi0baro avatar Jan 09 '25 14:01 gi0baro

@Kludex what's your current take on this? Should I rebase so it can be merged, or should we just forget about it?

I want this to get in, I want to get back to this soon. I can rebase myself.

Sorry the delay here.

Kludex avatar Jan 10 '25 08:01 Kludex

@Kludex not sure why the coverage fails after the last rebase..

gi0baro avatar Jan 13 '25 14:01 gi0baro

@Kludex not sure why the coverage fails after the last rebase..

Because we recently set branch = True on coverage.

Kludex avatar Jan 13 '25 15:01 Kludex

@Kludex sorry for the long delay.

This is now rebased on latest master, and tests/CI is finally green. Let me know if any additional edits are required for merge.

gi0baro avatar Mar 05 '25 11:03 gi0baro

Sorry the delay. Gradly you caught me at PyCon IT. 😅

Kludex avatar May 29 '25 13:05 Kludex