Enehizena Lawrence

Results 50 comments of Enehizena Lawrence

@aligurelli can you add more context to your question?

@ross-hugo increase the timeout to say `binance.WebsocketTimeout = time.Second * 100`

@elboletaire @jon4hz first off, for this issue, please ignore my comment here https://github.com/adshao/go-binance/issues/206#issuecomment-772557843, I was mixing up the keepAlive (websocket ping) with the keyAlive (user stream). I see now that...

@elboletaire the `keepAlive` call in the websocket_service is called for all WebSocket subscriptions - that `keepAlive` is for the WebSocket protocol, to keep the connection open. But for the user...

> > Exactly. Yeah it's true my case is for user streams and I know it's different and the other case should be fine for non-user streams; but the issue...

> > If this is unclear from the spec, then we should update the description of this method. > > I think a one part in the spec makes this...

@jcace please change the destination branch to dev, and also apply this middle to this echo instance https://github.com/application-research/estuary/blob/master/cmd/estuary-shuttle/main.go#L1050

> This impacts `collections` api. `collections` api uses a trailing slash to work. Without these, it'll return 404 and can impact the current users. why does it need a trailing...

@gmelodie I think we should add support to delete by `content ID` (single content) and `path` (multiple contents) using the body to specify the intention by content ID - deletes...

> Secondly, I think it's important to consider permissions before pushing these features to the main branch because this could cause issues with malicious users removing content from collections which...