Evgeniy Naydanov

Fix breackpoint_add for rtos swbp

2

breakpoint_add should use rtos only if request is done by gdb. If multiple targets are specified as -rtos , the rtos_update_threads was called only if the last target was specified...

Priority of mcontrol/mcontrol6 load data before trigger

1

There are two entries in table 10 (5.3. Priority)  and  AFAIK, both these entries specify the priority for `mcontrol/mcontrol6 load data before` (the second one explitly, the first...

`aarsize` field value for accessing `CSR_FRM` & `CSR_FFLAGS` registers

18

What is the correct value of `aarsize` when accessing `CSR_FRM` or `CSR_FFLAGS` ? As stated in the spec: > If aarsize specifies a size larger than the register’s actual size,...

target/riscv: check `abstractcs.busy`

2

According to the RISC-V Debug Spec (1.0.0-rc1)[3.7 Abstract Commands]: > While an abstract command is executing (busy in abstractcs is high), a debugger must not change hartsel, and must not...

target/riscv: read abstract args using batch

1

This would eliminate the need for an extra nop in-between the two reads in case of a 64-bit register.

Prior to the commit, it was impossible to get a `dmi.busy` responce on a scan in a batch that was not the first scan in the batch. Change-Id: Ib0714ecaf7d2e11878140d16d9aa6152ff20f1e9

This allows to merge the implementation in `batch.c` with the one in `riscv-013.c`. Change-Id: Ic3821a9ce2d75a7c6e618074679595ddefb14cfc

Track and clarify differences with upstream OpenOCD

4

After the most recent merge #976 the difference with upstream version used looks like so (some differences are omitted): ``` > git checkout 1f512eac32e614e893565741f93ea3739a522797 ... > git diff d4575b647a3603200a9bb4a784d170f792ab88d0 --stat...

It is needed since `register_read_direct` relies on `target->state` to work correctly. [The change, introducing the issue](https://github.com/riscv/riscv-openocd/pull/842/files#diff-701864e2be3210275085c84b8f6fa7f9eb6171a2a18ca71638be42a155c08c63R1760-R1769). There are two sullutions suggested so far: * [Using `riscv_halt_reason` and `set_debug_reason`](https://github.com/riscv/riscv-openocd/pull/842#discussion_r1183104333). * Using...