Eric Walker
Eric Walker
I did this recently in a project that has now diverged enough that I won't be able to easily put together a PR for this. From memory, switching to React...
@devil-ira sounds good. Just so I don't go off on a tangent, can you link to an example or two of methods you want to modify? I looked in [crates/bevy_ecs/src/world/entity_ref.rs](https://github.com/bevyengine/bevy/blob/main/crates/bevy_ecs/src/world/entity_ref.rs),...
Seems there's some errors that are being picked up in CI that I don't see in my smoke tests when running things locally. This evening or tomorrow I'll try to...
I was able to mostly repro what CI is doing by updating to the latest `stable` version using `rustup` and then running this command: ```sh $ cargo run -p ci...
@devil-ira is this good to go, or is there something else that will be needed?
> What you could use is impl IntoIterator which accepts both owned values and references. Done.
Might be good to move [this function](https://github.com/emwalker/bevy/blob/8eb0440f1ed0f075ed488e7efa36ba0f8bb37cad/crates/bevy_hierarchy/src/child_builder.rs#L69) and [this function](https://github.com/emwalker/bevy/blob/8eb0440f1ed0f075ed488e7efa36ba0f8bb37cad/crates/bevy_hierarchy/src/child_builder.rs#L53) over as well.
As I work through this PR, I'm beginning to wonder whether it improves upon the existing ergonomics, or whether it makes it harder to work with the `children` argument than...
Closing per this discussion: https://github.com/bevyengine/bevy/issues/7229#issuecomment-1465434249
^ @tensiondriven fyi