Emre Yigit
Emre Yigit
It is good to have `ClientRegressionWithMockNetworkTest.testOperationRedo` and `ClientRegressionWithMockNetworkTest.testOperationRedo_smartRoutingDisabled` tests with the solution.
Have a few small questions, rest looks nice.
Have a few small questions, rest is nice.
Hey, client must be disposed or shutdown somehow in order to get that exception. If no one disposed it, client may lost its connection and if can't reconnect, will be...
I'm okay with the PR, just have a small comment.
According to coverage report at GitHub actions, the coverage increased at least %1. I cannot compare fully right now since the PR is not seen at Codecov. After merged, I...
@srknzl this issue meant to be determine missing tests that decreases the public coverage. I just added few obvious tests while investigating. Real implementation will be handled in another issue....
Have reviewed all and commented.
Hi @thompson-tomo, the client doesn't support framework 4.5. In this case, we can't merge this PR. https://hazelcast.github.io/hazelcast-csharp-client/versions.html
This mainly comes from architecture of the Java client. I'm not sure whether we can make them public for C# client. Adding it to backlog, so we can have a...