Daniel Collin

icon indicating a website link https://mastodon.gamedev.place/@daniel_collin

icon company The Black Lotus icon location Karlskoga icon location Demoscener in TBL. Does Rust at home and work at Unity Technologies.

Results 324 comments of Daniel Collin

Disassembler

Also I'm not sure if you have push the `disassembler.rs` file

Disassembler

👍

Disassembler

Cool. I would suggest looking at https://github.com/Geal/nom for parsing in the assembler.

Consider using a codegen for glue

Yeah macro improvements are also on the way into Rust but likely will take a while before they get there. It's likely possible to do a combo of what Musashi...

Use a logging framework

Maybe this one? https://github.com/rust-lang-nursery/log Seems to be quite widely used.

Diff MAME version of Musashi with current

:+1:

Diff MAME version of Musashi with current

Ah.. Interesting :) This is something that one needs to make sure of to handle also: https://github.com/mamedev/mame/commit/b025f698a1c6a5c8dc4414f708f1f1699c0c2d02

Diff MAME version of Musashi with current

For the disassembler I found quite a bit of issues as well when I worked on this https://github.com/aquynh/capstone/blob/next/arch/M68K/M68KDisassembler.c I know I submitted a few changes back but I missed quite...

Diff MAME version of Musashi with current

Oh btw. Notice this clr on 000 https://github.com/mamedev/mame/commit/844e69607172242308670f67bb069bd6b5d0d40c

Diff MAME version of Musashi with current

Yeah I guess that is true.