Emily Rockman

Results 67 comments of Emily Rockman

Flaky test run: https://github.com/dbt-labs/dbt-core/actions/runs/7997092198

Everything passed in the previous run. I ran again and it's still passing. [Flaky Tester](https://github.com/dbt-labs/dbt-core/actions/runs/8005234305) ``` test_path: tests/functional/unit_testing/test_unit_testing.py::TestUnitTestExternalProjectNode::test_unit_test_ext_nodes python_version: 3.9 os: ubuntu-latest ``` [Flaky Tester](https://github.com/dbt-labs/dbt-core/actions/runs/8005239505) ``` tests/functional/unit_testing/test_unit_testing.py python_version: 3.9 os:...

Circling back and this has still not flaked a single time since the original occurrence. Closing as not flaky.

There are a few things happening here that cause the hang. First, we're logging Note events that have positional arguments that [we explicitly do not allow.](https://github.com/dbt-labs/dbt-core/blob/1c9cec17878ca0fec537a4cc13812f91ee97b29b/core/dbt/events/base_types.py#L64-L66). This assert should really...

Example PR: https://github.com/dbt-labs/dbt-core/pull/8258

logger.py wasn't removed and we're still depending on logbook. Reopening the issue.

Backing out these changes for now as cloud still has a codepath dependent on it. Will revisit.

Need to check that this isn't used in adapters as well. Might be easier/better to move it to the dbtMixin class.