Emily Rockman

Results 67 comments of Emily Rockman

@timle2 it's great that you're still interested in getting this over the finish line, even if it has to wait until September. Thanks so much! I did want to drop...

We're going to need to take a closer look to see if there is a reasonable place/way to determine when `Undefined` is being returned from jinja before this can be...

> Question: Would it be better to put the standard fields in an event_info dictionary or in the top-level of the message? I believe if we put the events in...

> Does it work to use the code as the message name? Why does it need to be defined with the code as the message name? I understand we can't...

Will need to change the above `for key in self.CONFIG_ARGS: ` to loop through all the keys in the dict, and if it's CONFIG_ARGS it's adde dot the config and...

Concerns: - If `compiled_sql` is used multiple times, we ideally wouldn't want to issue a Deprecation Warning for every time it's used, that's too repetitive - It's also unclear how...

Possible solution is to replace the dictionary with a class that implements the dictionary functions. Are we okay with issuing the deprecation warning multiple times since maybe you want to...

Thanks for the writeup @csoule-shaker. I'm not sure I understand so I'm going to need a bit of clarification on what you're asking for. Are you saying you have your...

@csoule-shaker and @jeremyyeo thank you for all the clarification. I'm on the same page as you now! I think @jeremyyeo is very close to the real issue with > There's...

This is great feedback, @csoule-shaker. I obviously missed that detail in the previous replies. @jeremyyeo opened #4868 (thank you!) to track what I discussed above. I'll leave this one open...