Emmanuel Thomé comments

Results 6 comments of


                                            Emmanuel Thomé

Support displaying sub-jobs of multibranch pipeline jobs.

Doh, there are already pull requests for that functionality. In contrast to other proposals, I'm not using the `depth` field of the json api. Using even `depth=1` has the drawback...

multipart/form-data parsing appears to truncate a file part by 1 byte

It's annoying indeed. I can't reproduce. Do you get that on every file? Here's what I get on a 1GB upload. It looks legit. ``` Index 24 offset 251658240 slice.size...

multipart/form-data parsing appears to truncate a file part by 1 byte

Given https://github.com/pallets/werkzeug/commit/77bde3337286c405280bef1870442be7f235393c it's probably a corner case that was missed and will be added to the test suite. Once we nail it down, creating on the fly a test file...

multipart/form-data parsing appears to truncate a file part by 1 byte

I'll have a much smaller one shortly.

multipart/form-data parsing appears to truncate a file part by 1 byte

A 64kb file created as: ``` (dd if=/dev/zero bs=65535 count=1 ; echo -ne '\015' ) > /tmp/z ``` eats the terminating 0x0d byte of the first upload (i.e., change chunkSize...

multipart/form-data parsing appears to truncate a file part by 1 byte

It should be OK. @davidism does that look fine to you? Are there other corner cases of this kind you can think of?