Emily Bache

Hi, sorry for the long silence. I havn't felt able to prioritize working on this recently. You've made some good suggestions and I need to spend some time looking into...

Support for parameterized tests is present in other ports of the approval test tool (see for example https://stackoverflow.com/questions/49035010/approvaltests-with-testcase-nunit-use-the-same-approval-file how it's done in C#). We should have this in the python...

That looks neat! How about putting this code in approvaltests/core/scenario_namer.py? Do you think you could also add a test to tests/test_scenarios.py? I'd like to better understand how this code works...

Honestly I thought it was already fixed. I know there's been quite a bit of development work done on python approvals lately. @isidore can you comment?

I'd be happy to get a pull request for Scrubbers. Ideally it would work in a similar way to the C++ Scrubbers: https://approvaltestscpp.readthedocs.io/en/latest/generated_docs/explanations/Scrubbers.html so an option to the verify function.

I would also like to see support for table-driven tests and the suggestion of using t.Name() seems much more sensible than parsing the stack trace.

I just made some changes that work for table-driven parameterized tests. I also addressed the linter problem with ignored errors, I think. I'm not sure what you mean by idiomatic...

Happy to hear that you're planning to do this! 1. If there is no CLI in Unity then just don't worry about it, no need to add this. If there...