Emily Bache

Results 28 comments of Emily Bache

I just updated this PR following conversation with Llewellyn. I think he probably wants to change a few more things too.

Ok so we should remove the seed so the behaviour is actually genuine. The threshold values in teh Alarm are supposed to be fixed at compile time actually. So maybe...

Thankyou so much for the code, that makes your query clearer for me. So the first test shouldn't be possible because you shouldn't be able to change the thresholds to...

ok so the random call is really _supposed_ to come up with a random float. If it's not then that's definitely a translation mistake! I don't particularly mind if it's...

Ok so sounds like the go version needs a re-write where Alarm and Sensor are in different packages so they can have a clearer interface. The randomness is there to...

I don't like this at all, sorry. I don't like declaring the prices function inside the create_app function. I think it should be declared at the top level of a...

Good idea. Can you link to the main texttest site ie https://texttest.org/ ?

I had a good look at this pull request and thought about it and decided not to accept it as-is. I have pushed some changes today that add a PyTestNamer...

You make good points! I'm away over Christmas, and I will take this up again in the new year.