Emil Ernerfeldt

Results 812 comments of Emil Ernerfeldt

First of all, there is a point of confusion here that need clearing up: `[s_stderr_indentation](https://github.com/emilk/loguru/blob/89f06b3919413b978a65eac71885f5c0d71b50c2/loguru.cpp#L204)` is thread-safe, because it uses atomics. It is thus intentionally, and safely, shared between threads....

Hi, thanks for your PR! Some notes `__declspec(thread)` was introduced in https://github.com/emilk/loguru/pull/36 by @justinian and I don't want to change that unless it still works on old VC versions. About...

Loguru is in passive maintenance mode. If you make a PR for it with some docs and everything is green, I will merge it! Make sure it compiles on all...

Will this still work on all Windows compilers, or do we need some compiler switch as well?

Could a user call `#include ` themselves before/after `#include `? If so, I would prefer that. One of the stated goals of Loguru is to keep the number of headers...

Windows compilations proves to be an ongoing issue for Loguru. Microsoft has in their infinitesimal wisdom decided to take standard function names and deprecate them and/or rename them, and do...

I think I might rework the fmtlib implementation at some point to have it use a specific suffix like this: ``` LOG_F(INFO, "Hello %s", "world"); LOG_S(INFO)

Any plans to make a nice PR of this?

I get this too. If I remember correctly XCode identifies as a terminal which supports colors – but it doesn't. The workaround it to set `loguru::g_colorlogtostderr = false;` when running...

I agree that porting some of these switches from compile-time to runtime would be a good idea. Pull requests welcome =)