Emilio Cobos Álvarez
Emilio Cobos Álvarez
The way we detect packed structs with `#pragma pack()` is a bit hacky, and fails for this case: https://github.com/rust-lang/rust-bindgen/blob/4d18f7606a2bc8a18b181b3e9639c9464a9dc896/src/ir/comp.rs#L1621-L1636 It's not particularly trivial to do better I think, but maybe...
Sorry for the lag here. Seems reasonable and should be easy to implement, patch welcome :)
(That said maybe just `--raw-line "pub use VkResult::*"` or so would be an appropriate workaround?)
Yes, making this the default based on the rust target seems like a great path forward. It seems `core_ffi_c` got stabilized already? A patch for this should be easy-ish to...
Yeah, this is somewhat annoying, but passing non-trivial arguments by value needs rustc support, and last time I checked with them they really weren't interested in implementing some kind of...
(The same happens for arguments, btw, we've run into this before, see https://bugzilla.mozilla.org/show_bug.cgi?id=1366247)
That'd yield also similar problems as #607, though.
Other user found this today wrapping a very simple C++ file: https://github.com/ssloy/tinyrenderer/blob/master/tgaimage.cpp (The call to `TGAImage::set` passes `TGAColor` by value, and that segfaults)
On 08/09/2017 10:41 PM, Vadim Chugunov wrote: > clang certainly does have the logic > > to figure out which types must be passed by-reference. Unfortunately, > this is not...
Should be trivial-ish to do this I think, thanks for the report!