Emilio Cobos Álvarez

Results 777 comments of Emilio Cobos Álvarez

I guess this is really an issue with whether `INT_MIN` is seen by bindgen on macOS, but maybe we can special-case and define them based on the target integer size.

A more precise definition is that bindgen will use `std::underlying_type_t`. But yeah, adding docs for this would be great.

Seems reasonable, would take a patch if it doesn't break backwards compat. Thanks.

Yeah this is sorta expected. You can set the type via `ParseCallbacks::int_macro`. The main problem with doing the above is that integer promotion rules in C and Rust are quite...

I don't think this is possible right now, but an annotation might be reasonable. What's the usecases for having the union be named? It cant' be named on C either.

Ok, so there are two things that have automatic names right now, one of them is `__bindgen_anon`, the other one is the union name itself (`RAM_TIMING__bindgen_ty_1`). I think an annotation...

In C all structs need to have a different address. It is unexpected that the size is four in windows though...

Ah, I didn't notice that... That's weird indeed, probably MSVC has a different ABI than gcc for empty structs and we're choking on it.

Ah, so I thought this was just a matter of something like https://github.com/rust-lang/rust-bindgen/pull/2246, but it seems `repr(packed(2))` in Rust has a different behavior than that C code, and I'm not...

We have other code for reading attributes see `warn_unused_result` in the tests. I don't expect this to be that much harder.