Emilia Hane

Results 55 comments of Emilia Hane

blocked by https://github.com/ethereum/hive/issues/1073

imo https://github.com/sigp/discv5/pull/250 solves this to a satisfactory degree. nonetheless, nodes behind NAT in geth for example, will never discover their local node id, and will never get a session. geth...

it should be possible to shorten lists of node ids with ```rust format!("[{:#}]", list.iter().format(", ")) ``` https://github.com/paradigmxyz/reth/issues/6080#issuecomment-1893329173

Now, it is ready for review. If you may @fjl .

> Right now, it isn't super clear from this text what the implementation requirements are. The text has both descriptions of implementation features and rationale-type content, where you explain 'common...

So this means the PING from the "receiver" to the "initiator" is dropped but places the entry in the "receiver's" state table for the "initiator's" PING to the "receiver" to...

What if the body of the RELAYREQUEST is changed to ```from_node_enr: Enr, to_node_id: NodeId```? Sending the enr of the initiator in the body will supply the receiver with the information...

I have implemented your protocol outline @pipermerriam with the changes in @AgeManning 's comment above. Furthermore I changed - [`{response: 2}`](https://github.com/emhane/discv5/blob/5c7662934f79191c7916a1a18f695efeee9a12d3/src/rpc.rs#L19-L21) is in the body of the `RELAYRESPONSE` assembled by...

I'm changing the `to_node_id` into `to_node_enr` in my implementation because otherwise a node has to store the enr of a peer that is potentially behind a NAT so that it...

Why divide up the receiving and sending with two encryption keys? It doesn't clearly state here where the sub-protocol session management should be done. I think it should be done...