Emanuel Peter
Emanuel Peter
Nice, the tests look good, thanks for adding them!
@dafedafe I recommend that you update the Bug title. It names "offsets", but really you probably want to name "indices and mask", or just "masked and gather/scatter vector operations". And...
@tabjy I am re-running testing, then will re-review. /reviewers 2 reviewer
/reviewers 2 reviewer @chhagedorn told me he would also like to review this. I will also run testing again.
@chhagedorn should we change the regex to have a space at the end, so that we do not do this kind of prefix-matching?
@tabjy Are you planning to keep working on this? I talked with @chhagedorn and we would like you to change the IR rule to something like `@IR(counts = {IRNode.CMP_U +...
@tabjy Yes, looks like the 32-bit VM behaves different. Do you know what makes the difference here? Yes, looks like regex-matching is also confused here, we should probably address that....
FYI going on vacation, so feel free to ask others to review!
@reinrich thanks for taking this up! Just did a quick scan of the tests. I think it could be good to have both big/small endian tests run on both big/small...
@dean-long @reinrich Yes, I guess that is a generalization that could be made. It would require a lot more tests to make sure all combinations are checked. I would suggest...