Emanuel Peter

@Hamlin-Li Thanks for the work and your response! Ah, I see now. This is a `manual` test. I did not even know that this mode existed! A few comments: -...

I see that `LoadVectorNode` has no additional slots, but then `LoadVectorMaskedNode` and `LoadVectorGatherMaskedNode` simply do `add_req`. Why not just compare these extra slots (as many as there are) in `LoadVectorNode::Identity`,...

> It seems that your code would now disallow such a case, because you always check that the Ideal node you get back is of the same type as the...

@dafedafe Nice, I think this already looks much better. Let me know if/when you want me to look at it again ;)

I've randomly thought about this change again (while trying to sleep yesterday...). And started worrying about this kind of case: ``` import jdk.incubator.vector.*; public class Test { private static final...

Nice, ah you are right, there can be issues with mask-only cases as well! It would be great if you had tests that exactly exercise these "bad" examples, where it...

About storing a `IntVector` to memory, and then loading as `FloatVector`: You can use a `MemorySegment`: ``` // Wrap an array into a MemorySegment MemorySegment ms = MemorySegment.fromArray(new byte[10_000]); //...

@dafedafe I also scanned quickly over the regression tests. I see at least two aspects missing: - No mixed type test for load-store: Use MemorySegment `from/intoMmemorySegment`. Try something like store...

Ah, some more missing cases: - Do some store-store and store-load cases where you the first and second are different loads/stores, i.e. one with and one without mask/offsets. E.g. `StoreVectorMasked`...

> It looks as if load/stores that use from/intoMemorySegment with different types apparently don’t create LoadVector nodes. It seems that fromMemorySegment tries to inline the VectorSupport::load intrinsic, but fails as...