Emanuel Peter

/reviewers 2 reviewer I'll look at it again, once my concerns are all addressed. @Bhavana-Kilambi feel free to ping me again for that.

> I am not sure if I fully understand what's expected in the JTREG tests. Should I be verifying the -XX:+PrintIdeal output to make sure the correct message is being...

@Bhavana-Kilambi I know we have the tests in `test/hotspot/jtreg/compiler/c2/irTests/TestDisableAutoVectOpcodes.java`, and some other reduction tests. But these do not do the specific think I would like to see. I would like...

@chhagedorn I think I have addressed all your remarks. I agree I could have probably split the `PairSet` and `PackSet` into separate RFE's, that only became apparent once I did...

@chhagedorn thanks very much for the review, there were some great suggestions! I fixed almost all, and left some responses at the others. I'll repeat them here: ------------ You are...

Thanks @chhagedorn for the detailed review, thanks also @vnkozlov ! /integrate

@merykitty I just discussed the testing with @TobiHartmann . He just came across this test: `test/hotspot/jtreg/compiler/c2/TestUnsignedByteCompare1.java`. The cool thing is that you can "simulate" constants with `MethodHandles.constant`. At runtime apparently...

@merykitty I'm mostly out of the office until September 9 (FYI). It would be really cool if this made it in. I'm currently playing with `MethodHandles.constant`, and it is really...

It would be nice to also have different kinds of inputs: randomized, and for floats also inf, nan, etc.

Also: I think your new tests should not go into an old "cr" directory. With `grep "Math.round" test/hotspot/jtreg/compiler/ -r` I see there are other tests in better directories.