ember91

Results 20 comments of ember91

Code Error in 4_container_images.sh

This can be closed due to #17

directories referenced

This can be closed

Does not respect .clang-format-ignore

This may be an issue with clang-format and not the extension. To be precise an issue with the clang-format `-assume-filename` option not playing nicely with `.clang-format-ignore`. See https://github.com/microsoft/vscode-cpptools/issues/13005 and https://github.com/llvm/llvm-project/issues/113099.

N816 considers generator/list comprehensions to be globally scoped

I tested this with Python 3.11.5. But which rule is supposed to catch this then if not N816?

N816 considers generator/list comprehensions to be globally scoped

I'm a bit lost here. Eliminate what behavior of the check? That it identifies mixed case variables in comprehensions?

N816 considers generator/list comprehensions to be globally scoped

Any more input here? @sigmavirus24 @dhruvmanila

On Windows, use CP_UTF8 over CP_OEMCP for output

Yes I don't claim that the result will be much better because it supports more characters; both will with your ACP and OEM encodings support the same number of characters...

On Windows, use CP_UTF8 over CP_OEMCP for output

Try adding 'SetConsoleOutputCP(CP_UTF8);' at the initialization of the application. Although note that it's Windows-only, so hide it behind a define.

On Windows, use CP_UTF8 over CP_OEMCP for output

If you have interactive terminal input you need `SetConsoleCP` as well. But I'm guessing you don't. To me the changes look fine. With just a quick read it seems like...

On Windows, use CP_UTF8 over CP_OEMCP for output

I can make the changes. Three things: * I can't find `clambc.c` you mentioned but I think I have added it in the files that matter that have a `main()`...