Emanuel Steen

icon company Thales icon location Austin, Texas, USA icon location Loves open source and automation. Born in Sweden, spent a couple of year in Singapore and now a software engineer at Thales in Austin, Texas.

Results 2 comments of Emanuel Steen

Only clean up /etc/fstab if it really contains Vagrant data

FYI, initially I planned to modify https://github.com/hashicorp/vagrant/blob/main/lib/vagrant/action/builtin/synced_folders.rb#L140 to never even call `persist_mount_shared_folder` (https://github.com/hashicorp/vagrant/blob/78bc0243338cd3b271226cefd9ae21f0ed985065/plugins/guests/linux/cap/persist_mount_shared_folder.rb#L19). But there are explicit tests to validate that this function is called with a `nil` argument (https://github.com/hashicorp/vagrant/blob/78bc0243338cd3b271226cefd9ae21f0ed985065/test/unit/vagrant/action/builtin/synced_folders_test.rb#L250)....

Only clean up /etc/fstab if it really contains Vagrant data

Looks like it needs a review approval to be merged. Personally, I still run a custom build of Vagrant with this patch.