Artyom Sovetnikov

Results 87 comments of Artyom Sovetnikov

Yeah, I've thought about muting the warnings, but hopefully we can find a way to detect whether the nullable defines are actually required. If not, disabling the warnings will work,...

Thanks for the info! I've actually tried `compilation.Options.NullableContextOptions`, but it didn't work in unit tests. Probably because the tests project had nullables disabled, but it also ignored the define in...

Thank you. I'm not familiar with `patch` command. Will it work no matter the spacing/formatting of the target file? Actual output after building the runtime is not equal to what...

Just to be sure we have to check if it actually works. If you have time, please run the entire `compile-runtime.sh` and commit the resulting `dotnet.js`. Otherwise, we can leave...

Here is the instructions on building the runtime: https://github.com/Elringus/DotNetJS#compiling-runtime Make sure to run `install-emsdk.sh` prior to compiling, it will take care of setting the env vars.

Ok, so I've tested and it doesn't seem to work. Here is the result of running the patch command: ``` patching file native/dotnet.js Hunk #1 FAILED at 4398. Hunk #2...

I've also noticed that the auto-generated file has some random contents (hashes), so this kind of patching may not work.

> Actual output after building the runtime is not equal to what is currently stored in the repo, as I've formatted it for better readability during debug/discussions.

Is this about this line: https://github.com/Elringus/DotNetJS/blob/cad9a87854fd860203d25991a55bb3a68fa11229/DotNet/Packer/LibraryGenerator/LibraryTemplate.cs#L11 ? It should only invoke in node environment, so `global` should be accessible.

If it's that line, can you please test if the following will work with angular: ``` factory(module.exports, global || window); ```