Elvis Pranskevichus comments

Results 441 comments of


                                            Elvis Pranskevichus

Adds max_consecutive_exceptions to pool

There's the private `Pool._get_new_connection()`, which we can make public.

connection.close is throwing protocol error

Interesting. Can you show the source for your `read()` function?

connection.close is throwing protocol error

It looks like a race. The protocol handler is receiving data from the server while not expecting anything. Is `finally` called normally or is there a preceding exception?

Implement edgedb instance start for cloud instances

Yes, cloud instances should be able to go into a "stopped" state (i.e. not serving and not consuming any resources other than storage).

better errors in `edgedb instance create`

> Do we know when it have reached? Sure, if we got a response from server.

Constraint: insert one object type or the other, but not both.

The ISE wrapping _is_ a (usability) bug though.

Syntactic sugar for "set if not empty"

`insert` can benefit from this too, `?:=` would mean "if empty, use default".

Syntactic sugar for "set if not empty"

Yeah, this should cover enough of use cases to make #4595 unnecessary,

Edgedb dump -> restore onto non-empty database with only extensions isn't rejected

Hmm. Is there a chance you're restoring into a non-empty database? The bug seems to be that the CLI fails to recognize that the schema is non-empty.

Edgedb dump -> restore onto non-empty database with only extensions isn't rejected

I couldn't reproduce. Steps (as written) attempt `restore` twice into the same db, no?