Emilio López

Results 175 comments of Emilio López

Hi! It looks like you're not doing a foundry build with build info; you need to replicate the build the way crytic-compile does it when you use ignore-compile: https://github.com/crytic/crytic-compile/blob/master/crytic_compile/platform/foundry.py#L56-L61 In...

Hi! https://github.com/crytic/slither/pull/2521 was only merged very recently, so it's not yet available on any release. I'm guessing you could use `rev: master` in the meantime, but I'll defer to @dbast...

Hi! Thanks for the report, do you have a repo you can share to take a look at the issue? If you roll back to version 0.3.1 of the action,...

Hi @WardenJakx ! yes, you can use the `slither-version` option in the action: https://github.com/crytic/slither-action?tab=readme-ov-file#using-a-different-slither-version You can report the performance regression in the Slither repository: https://github.com/crytic/slither/issues/new/choose If you can provide a...

Hi! thanks for the report. It looks like the optimism scanner includes the word "etherscan" on the URL, causing the check implemented here not be accurate: https://github.com/crytic/crytic-compile/blob/603218d/crytic_compile/platform/etherscan.py#L252-L287 We should rework...

This is no longer an issue after we introduced Etherscan v2 API support in 0.3.8

Hi! Do you have a binary called `solc-0.4.25` on your system and in `PATH`? The `--solc` flag takes a path to the solc compiler. I'm assuming you wanted to run...

Hi! Thanks for the report. The error is thrown when the import fails: https://github.com/crytic/slither/blob/master/slither/tools/similarity/model.py I'm not sure why that wouldn't work with pipx in particular; can you get a shell...

Thanks for the pointers! I'll take a look at that other repository when I get a chance, and I'll see if I can spot the problem there.

Hi @nmote! The issue should be resolved upstream now, what are the next steps to update Semgrep's version of it?