slither-action icon indicating copy to clipboard operation
slither-action copied to clipboard

Versions after 0.3.2 take extremely long

Open WardenJakx opened this issue 1 year ago • 4 comments

What

  • before 0.3.2 slither would take ~5m to run
  • In the PR updating from slither 0.3.1 to 0.3.2 slither went from 5m to 2 hours (no other changes were made in the repo)
  • Even after updating to 0.4.0 the time is still 2h
  • Seems like ** something ** hangs after slither goes through the repo. It just stays in this completed hang state for a while before finishing (maybe related to https://github.com/crytic/slither-action/pull/76)

0.3.2

image

0.3.1

image

WardenJakx avatar May 09 '24 20:05 WardenJakx

Hi! Thanks for the report, do you have a repo you can share to take a look at the issue? If you roll back to version 0.3.1 of the action, does it still take 5min nowadays? I'm thinking it could be an issue on slither itself, as slither v0.10.2 got released around the same time as v0.3.2 of the action.

elopez avatar May 09 '24 20:05 elopez

Hi, 0.3.1 still yields the same result now. Is there a way to pin the slither version used in action?

WardenJakx avatar May 13 '24 16:05 WardenJakx

Hi @WardenJakx ! yes, you can use the slither-version option in the action: https://github.com/crytic/slither-action?tab=readme-ov-file#using-a-different-slither-version

You can report the performance regression in the Slither repository: https://github.com/crytic/slither/issues/new/choose If you can provide a link to the codebase that triggers the problem that might ease identifying the cause of the regression.

elopez avatar May 13 '24 16:05 elopez

unfortunately the codebase is closed source so i cannot provide additional context :(

however, after pinning the slither version to v0.10.1 everything went back to normal!

I was even able to update to slither-action 0.4.0 with no issues

WardenJakx avatar May 13 '24 18:05 WardenJakx