Elon Gliksberg

Results 57 comments of Elon Gliksberg

Hi @jtcohen6 @lostmygithubaccount, I'm thinking of picking this task up soon. I would appreciate a confirmation that this feature could be merged once implemented and reviewed. Thanks.

This is now supported.

Introduced a `var` called `disable_tests_results`.

Hi @DakotaMichael, could you perhaps elaborate a bit on the use-case or the problem you're trying to solve? Thanks.

Hi @cburroughs, thanks for opening this PR. Care to share about the motivation for the change? I agree that in retrospect, it may have been better to do it this...

Hi @mhindery, may I ask why don't you use a separate [venv](https://docs.python.org/3/library/venv.html) for the other application?

The solution should probably be: ```sh ELEMENTARY_PKG_LOCATION=$(pip show elementary-data | grep -i location | awk '{print $2}') ELEMENTARY_DBT_PROJECT_PATH="$ELEMENTARY_PKG_LOCATION/elementary/monitor/dbt_project" dbt deps --project-dir "$ELEMENTARY_DBT_PROJECT_PATH" ``` Or reading [this](https://github.com/elementary-data/elementary/blob/ec17900a8f5712061b32024c600d05c9c9b411fa/elementary/monitor/dbt_project_utils.py#L11-L12) variable via Python code.

This image is not yet resolved because `edr` still installs the `dbt_packages` under `site-packages` which is owned by `root`.

Hi @menzenski, you can do it by filling the values in this [macro](https://github.com/elementary-data/dbt-data-reliability/blob/b234a2f460813d477b87ef464a7350270da0c843/macros/edr/dbt_artifacts/upload_dbt_invocation.sql#L0-L1). Here's our [contribution guide](https://github.com/elementary-data/dbt-data-reliability/blob/master/CONTRIBUTING.md). Let me know if you need any help.

1. How common is it that dbt users define other projects as packages? 2. When doing so, do they _not_ generate report for the other projects? Because otherwise we could...